Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pmd): update PMD rules and fix issues #687

Merged
merged 6 commits into from
Dec 17, 2022
Merged

build(pmd): update PMD rules and fix issues #687

merged 6 commits into from
Dec 17, 2022

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Nov 12, 2022

Contains

Updated and customized rules for PMD, adjusted for the launcher project.

All issues have been adressed such that we no longer ignore PMD errors and instead will fail a build if new issues occur.

  • build(pmd): use custom PDM rules for the launcher
  • build(pmd): adjust custom rules

How to test

Run the PMD checks locally via

gradlew pmdMain
gradlew pmdTest

Run the CheckStyle checks locally via

gradlew checkstyleMain
gradlew checkstyleTest

Or run everything at once via

gradlew check -x test

Outstanding before merging

  • fix reported PMD issues or suppress warnings
  • fix reported CheckStyle issues or suppress warnings

Start with 'category/java/errorprone.xml' and exclude or configure individual rules to fit to the project.
@skaldarnar skaldarnar added Type: Maintenance Maintenance or chores not adding new features or fixing bugs. Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) labels Nov 12, 2022
@skaldarnar skaldarnar added this to the v4.8.0 milestone Nov 12, 2022
@jdrueckert jdrueckert merged commit cfa8ce0 into master Dec 17, 2022
@jdrueckert jdrueckert deleted the chore/pmd branch December 17, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: CI/CD Related to CI/CD and build infrastructure (excluded from the Changelog) Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants