-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove game profile selection (fixed on OMEGA) #684
Conversation
- feat: remove the game profile combo box from the FXML and the controller - feat: manage the launcher configuration `config` as property to better handle delayed initialization - chore: move more initialization code from `ApplicationController#update` to `ApplicationController#initialize` - feat: initialize game release combo box as soon as the launcher configuration is available - fix: check for remaining disk space each time the installed games change
final GameManager gameManager = new GameManager(cacheDirectory, gameDirectory); | ||
Set<GameIdentifier> installedGames = gameManager.getInstalledGames(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we call getInstalledGames()
in other situations or can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, in the application controller:
TerasologyLauncher/src/main/java/org/terasology/launcher/ui/ApplicationController.java
Lines 274 to 276 in f5998e3
// bind the application controller's view of the installed games to that of the game manager. that way, we also | |
// get notified if the installed games are changed from a different thread (DeleteTask or DownloadTask). | |
Bindings.bindContent(installedGames, gameManager.getInstalledGames()); |
Contains
ApplicationController
ApplicationController#update
toApplicationController#initialize
FooterController
Contributes to #677.
How to test
Start the launcher.
The game profile selection box ("Terasology" vs "Terasology Lite") should no longer be visible.
The game release selection box should contain the releases (and pre-releases, if enabled in the settings) of Omega builds.
Downloading and starting Omega releases should still work as before.
Outstanding before merging
ApplicationController#downloadAction
TerasologyLauncher/src/main/java/org/terasology/launcher/ui/ApplicationController.java
Line 419 in d973d4f
Improve on the UI in a follow-up PR and clean up unused code in the progress.