feat: remove game profile selection (fixed on OMEGA) #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: remove the game profile combo box from the FXML and the controller - feat: manage the launcher configuration `config` as property to better handle delayed initialization - chore: move more initialization code from `ApplicationController#update` to `ApplicationController#initialize` - feat: initialize game release combo box as soon as the launcher configuration is available - fix: check for remaining disk space each time the installed games change
skaldarnar
changed the title
skaldarnar
added
Type: Enhancement
jdrueckert
reviewed
Nov 6, 2022
| final GameManager gameManager = new GameManager(cacheDirectory, gameDirectory); | ||
| Set<GameIdentifier> installedGames = gameManager.getInstalledGames(); |
There was a problem hiding this comment.
do we call getInstalledGames() in other situations or can it be removed?
There was a problem hiding this comment.
Likewise, in the application controller:
jdrueckert
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
ApplicationControllerApplicationController#updatetoApplicationController#initializeFooterControllerContributes to #677.
How to test
Start the launcher.
The game profile selection box ("Terasology" vs "Terasology Lite") should no longer be visible.
The game release selection box should contain the releases (and pre-releases, if enabled in the settings) of Omega builds.
Downloading and starting Omega releases should still work as before.
Outstanding before merging
ApplicationController#downloadActionTerasologyLauncher/src/main/java/org/terasology/launcher/ui/ApplicationController.java
Line 419 in d973d4f
Improve on the UI in a follow-up PR and clean up unused code in the progress.