i18n: reduce log spam for missing labels #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build up an index at runtime to remember which translations are missing and only log them once.
skaldarnar
added
Type: Enhancement
jdrueckert
approved these changes
Nov 3, 2022
skaldarnar
added a commit
that referenced
this pull request
Nov 4, 2022
* i18n: use properties and bindings for i18n of resources bundles - slim down `Languages` and merge it with `BundleUtils` - rename `BundleUtils` >>> `I18N`, now holding utility for translating resource bundles in general - add small FX-utility to `I18N` to create a `Tooltip` with a string binding - migrate both application and settings controller to use string bindings for labels - use `Locale`s as value for the language selection and use custom cell renderer for icon and translated text Based on https://sodocumentation.net/javafx/topic/5434/internationalization-in-javafx * chore: fix checkstyle error-level finding * i18n: reduce log spam for missing labels (#681) Build up an index at runtime to remember which translations are missing and only log them once. * i18n: translate both selected and other entries in Java memory combo boxes Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Build up an index at runtime to remember which translations are missing and only log them once.
How to test
Go to the launcher settings and change the language.
Select a langauge with missing translations (German, French, and Italian definitely have missing translations for some labels).
The launcher log should print WARN logs about the missing translations only once.
Switching back and forth between those locales should not yield further log output.
Outstanding before merging
Based on #679.