-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(GameIdentifier): remove engineVersion; rename String version to displayVersion #655
Conversation
JenkinsRepositoryAdapter is not quite back to its pre-#647 behavior: 8d928d3...fix/removeEngineVersion#diff-0aa9f2a209932ac1aa89399ead549d10d3cea93f42394eafb59542b2f409ed93L99-R99 TerasologyLauncher/src/main/java/org/terasology/launcher/repositories/JenkinsRepositoryAdapter.java Lines 96 to 100 in 801d347
ignores jenkinsBuildInfo.number and is using the versionInfo.properties buildNumber instead. @skaldarnar What do we want here, in the interim before we get distribution versioning?
|
Hm, let me try to list the pros and cons that come to my mind here:
As the launcher controls how games are installed (and just dropping games manually in the install dir is neither recommended nor in any way supported) we could live with getting the build number from the Repository and persisting it with an installation of the game (to be able to match it back).
I think the situation here may get better when we also change how |
…insBuildInfo Update comment to clarify that Jenkins.Build.number is NOT versionInfo.buildNumber.
I've put it back to the pre-#647 method of using the distribution Jenkins.Build.number. |
See discussion.
Companion to #654. Split in hopes of more reviewable changes.
Contributes to #651.
Largely reverts e1e530f (#647). Reviewers may want to compare this to the state of things before #647:
8d928d37a1c59bfb375899fb115c7c4abd836b13...fix/removeEngineVersion
#diff-eb9f4ead54I think the GameManager and RepositoryAdapters are what want the closest scrutiny there.