-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update JNBullet to 1.0.4 #5225
Conversation
✅ tests out fine on M1 Mac (_I can build and start the game into the main menu, running the game crashes due to some OpenGL error. I think the Vulkan workstream had made some progress in that direction.) |
Tests out fine on Linux and Windows |
3625fcb
to
7abf2d0
Compare
Everything should be ready for releasing JNBullet v1.0.4. It just needs a final non-snapshot release to be published now. |
build.gradle.kts
Outdated
@@ -98,7 +98,7 @@ dependencies { | |||
natives(group = "org.terasology.jnlua", name = "jnlua_natives", version = "0.1.0-SNAPSHOT", ext = "zip") | |||
|
|||
// Natives for JNBullet | |||
natives(group = "org.terasology.jnbullet", name = "JNBullet", version = "1.0.2", ext = "zip") | |||
natives(group = "org.terasology.jnbullet", name = "JNBullet", version = "1.0.4-SNAPSHOT", ext = "zip") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to have release versions not snapshot versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's exactly why the PR wasn't merged before and why I updated it with 496bdaf 🤔
Contains
With JNBullet v1.0.4(-SNAPSHOT) we bundle natives for both Intel and Apple Silicon Macs.
Nothing should change for Linux and Windows.
Related to MovingBlocks/JNBullet#15.
Contributes to #5055.
How to test
Just checkout this PR and run the game from source.
Outstanding before merging