Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: link TypeHandlerLibrary readme #5222

Merged
merged 2 commits into from
Mar 13, 2024
Merged

doc: link TypeHandlerLibrary readme #5222

merged 2 commits into from
Mar 13, 2024

Conversation

jdrueckert
Copy link
Member

No description provided.

@jdrueckert jdrueckert added Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Type: Chore Request for or implementation of maintenance changes labels Mar 10, 2024
@jdrueckert jdrueckert self-assigned this Mar 10, 2024
@jdrueckert
Copy link
Member Author

jdrueckert commented Mar 10, 2024

@skaldarnar regarding the recent serialization changes, we did talk about documenting our decision and motivation (for example in the form of a mini-ADR or similar)... do you think detailed documentation in BSA's PR + a reference to it in the docs I change here would be sufficient?
If so, feel free to hijack the PR and add a respective passage.

Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is, these changes are fine.

Regarding serialisation changes to private fields, I believe the motivation was both ideological (you should not violate encapsulation), as well as practical (Java 17 forbids accessing private members of core library classes via reflection already). A brief note explaining this may be a useful addition, although I wonder if serialising private fields was considered unexpected behaviour in the first place anyway.

@jdrueckert
Copy link
Member Author

talked to @skaldarnar - he says to merge this and he'll create a separate PR

@skaldarnar skaldarnar merged commit 1b48033 into develop Mar 13, 2024
9 checks passed
@skaldarnar skaldarnar deleted the doc/thl-link branch March 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Type: Chore Request for or implementation of maintenance changes
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants