Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: address PMD GuardLogStatement warnings #5209

Merged
merged 30 commits into from
May 17, 2024
Merged

qa: address PMD GuardLogStatement warnings #5209

merged 30 commits into from
May 17, 2024

Commits on May 13, 2024

  1. qa engine, audio, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3b23f5d View commit details
    Browse the repository at this point in the history

  2. qa engine, config, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e9c4f14 View commit details
    Browse the repository at this point in the history

  3. qa engine, core, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    496fcca View commit details
    Browse the repository at this point in the history

  4. qa engine, entitySystem, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6611111 View commit details
    Browse the repository at this point in the history

  5. qa engine, game, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    23e58cc View commit details
    Browse the repository at this point in the history

  6. qa engine, identity, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c182e76 View commit details
    Browse the repository at this point in the history

  7. qa engine, input, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    cf84823 View commit details
    Browse the repository at this point in the history

  8. qa engine, logic, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f0b2bab View commit details
    Browse the repository at this point in the history

  9. qa engine, network, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d5a0dba View commit details
    Browse the repository at this point in the history

  10. qa engine, particles, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3f69b34 View commit details
    Browse the repository at this point in the history

  11. qa engine, persistence, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c1230d3 View commit details
    Browse the repository at this point in the history

  12. qa engine, physics, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3cd9936 View commit details
    Browse the repository at this point in the history

  13. qa engine, recording, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c3c6c4b View commit details
    Browse the repository at this point in the history

  14. qa engine, registry, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    87fae23 View commit details
    Browse the repository at this point in the history

  15. qa engine, rendering, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f4487b8 View commit details
    Browse the repository at this point in the history

  16. qa engine, utilities, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1a7fe0b View commit details
    Browse the repository at this point in the history

  17. qa engine, world, fluent logger.

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2a293e5 View commit details
    Browse the repository at this point in the history

  18. review feedback pr 

    introduce local varaible where necessary, otherwise ignore warning
for the sake of shorter log message line.
    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    be19e62 View commit details
    Browse the repository at this point in the history

  19. feedback fluent-logger pr. except to make log line shorter. 

    Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
    @soloturn @jdrueckert
    soloturn and jdrueckert committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e9fad3d View commit details
    Browse the repository at this point in the history

  20. Update engine/src/main/java/org/terasology/engine/rendering/opengl/Op… 

    …enGLTexture.java

Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
    @soloturn @jdrueckert
    soloturn and jdrueckert committed May 13, 2024
    Configuration menu
    Copy the full SHA
    cf50c8e View commit details
    Browse the repository at this point in the history

  21. line length warning removed

    @soloturn
    soloturn committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f8b792c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. refactor: use less verbose varient of fluent API

    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    12ae29a View commit details
    Browse the repository at this point in the history

  2. fix: //NOPMD doesn't work if log spans multiple lines 

    - removed line break or switched back to fluent API (using less verbose variant though)
    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3705eff View commit details
    Browse the repository at this point in the history

  3. refactor: introduce and reference local variables

    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c48561f View commit details
    Browse the repository at this point in the history

  4. refactor: suppress guardlogstatement warnings for methods intended fo… 

    …r logging
    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    56f9ed8 View commit details
    Browse the repository at this point in the history

  5. revert: unnecessary usage of fluent API

    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e4cb5fc View commit details
    Browse the repository at this point in the history

  6. qa: address remaining PMD guardlogstatement warnings

    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2f15a82 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into qa/fluent-logger

    @jdrueckert
    jdrueckert authored May 17, 2024
    Configuration menu
    Copy the full SHA
    eb7ed68 View commit details
    Browse the repository at this point in the history

  8. fix: log format

    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4ad29ed View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/qa/fluent-logger' into qa/fluent… 

    …-logger
    @jdrueckert
    jdrueckert committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f4b34ff View commit details
    Browse the repository at this point in the history