prepare switch over to kotlin, "new" java date formatting #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
force-pushed
the
qa/prep-kotlin
branch
2 times, most recently
from
8ef5bd2
to
a5352e5
Compare
soloturn
force-pushed
the
qa/prep-kotlin
branch
2 times, most recently
from
5ebb8c7
to
7f0542d
Compare
soloturn
force-pushed
the
qa/prep-kotlin
branch
from
7f0542d
to
6a40f46
Compare
BenjaminAmos
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
These changes appear fairly self-explanatory.
One thing to be aware of is that double quotes in Groovy are actually GString types, rather than String. Single quotes are string literals ("real" String instances). Groovy usually converts seamlessles between the two though, so it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle groovy allows quite similar syntax for groovy and kotlin, do a first step to switch over to kotlin by replacing quotes, use java date formatting introduced in java-8, and register some tasks so they do not get configured when not executed.