Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-8.5, full java-21 support. #5189

Merged
merged 3 commits into from
Dec 5, 2023
Merged

gradle-8.5, full java-21 support. #5189

merged 3 commits into from
Dec 5, 2023

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Dec 4, 2023

update gradle to version with full java-21 support, junit-bom, lwjgl-bom minor upgrades. as well idea intellij to newer kotlin with current version.

@BenjaminAmos BenjaminAmos marked this pull request as draft December 4, 2023 19:18
@BenjaminAmos
Copy link
Contributor

Just for future notice, if you don't want a pull request to be merged yet then you can mark it as a draft. GitHub prevents us from merging draft pull requests until the draft status is removed. I've just marked this pull request as a draft for you. When you're ready for it to be reviewed, you can click the "Ready for review" button to remove the draft status.

@soloturn soloturn marked this pull request as ready for review December 5, 2023 05:35
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me and game compilation and start still work.

@jdrueckert jdrueckert merged commit 1b57c1b into develop Dec 5, 2023
9 checks passed
@jdrueckert jdrueckert deleted the qa/update-versions branch December 5, 2023 17:04
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 3 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants