Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move readme images back into docs folder #5163

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: move readme images back into docs folder #5163

merged 2 commits into from
Nov 8, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Nov 6, 2023 •
edited
Loading

Without fix

image

With fix

image

@github-actions github-actions bot added Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Type: Bug Issues reporting and PRs fixing problems labels Nov 6, 2023
@jdrueckert jdrueckert marked this pull request as ready for review November 6, 2023 20:59
@jdrueckert jdrueckert mentioned this pull request Nov 6, 2023
Merged
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 2 milestone Nov 6, 2023
@jdrueckert jdrueckert merged commit 7d66366 into develop Nov 8, 2023
9 checks passed
@jdrueckert jdrueckert deleted the fix/broken-readme-images branch November 8, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloturn soloturn soloturn approved these changes

@BenjaminAmos BenjaminAmos BenjaminAmos approved these changes

Assignees
No one assigned
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
2023 Revive - Milestone 2
Development

Successfully merging this pull request may close these issues.
3 participants
@jdrueckert @soloturn @BenjaminAmos