Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: address IntelliJ QAPlug plugin findings #5149

Merged
merged 35 commits into from
Nov 11, 2023
Merged

refactor: address IntelliJ QAPlug plugin findings #5149

merged 35 commits into from
Nov 11, 2023

Commits on Oct 22, 2023

  1. qa: make final fields static

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    aa6ca30 View commit details
    Browse the repository at this point in the history

  2. qa: remove unnecessary local before return

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    1a53322 View commit details
    Browse the repository at this point in the history

  3. qa: avoid instanceof checks in catch clause

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    db4f626 View commit details
    Browse the repository at this point in the history

  4. qa: method/constructor should not throw java.lang.Exception

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    e3d80fb View commit details
    Browse the repository at this point in the history

  5. qa: instanceof check covers null check

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f22c1fa View commit details
    Browse the repository at this point in the history

  6. qa: avoid toString on String objects

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    9d7204b View commit details
    Browse the repository at this point in the history

  7. qa: remove overrides that only call their super

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    993b370 View commit details
    Browse the repository at this point in the history

  8. qa: remove unused private methods

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    315ef35 View commit details
    Browse the repository at this point in the history

  9. qa: if statement nesting not necessary

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    3c5d507 View commit details
    Browse the repository at this point in the history

  10. qa: remove unused local variable

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    df3539a View commit details
    Browse the repository at this point in the history

  11. qa: close resources after use

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b0ec929 View commit details
    Browse the repository at this point in the history

  12. qa: use equals() to compare object references

    @jdrueckert
    jdrueckert committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    06c5fcf View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge branch 'develop' into chore/qaplug-findings

    @jdrueckert
    jdrueckert authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3428369 View commit details
    Browse the repository at this point in the history

  2. fix: reintroduce override, needed to elevate access modifier 

    - add pmd suppression for UselessOverridingMethod rule
    @jdrueckert
    jdrueckert committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a3f8fbc View commit details
    Browse the repository at this point in the history

  3. fix: exception type in override

    @jdrueckert
    jdrueckert committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    760a174 View commit details
    Browse the repository at this point in the history

  4. chore: replace invalid javadoc character with unicode representation

    @jdrueckert
    jdrueckert committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f067ba2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. javadoc: fix broken references

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    077d488 View commit details
    Browse the repository at this point in the history

  2. javadoc: fix disallowed self-closing and empty elements

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    6a816ed View commit details
    Browse the repository at this point in the history

  3. javadoc: fix invalid uses of @param and @return

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    a27bd8e View commit details
    Browse the repository at this point in the history

  4. javadoc: fix bad use of symbols

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    c93ad63 View commit details
    Browse the repository at this point in the history

  5. javadoc: fix disallowed list item tag without surrounding list

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ad27ad0 View commit details
    Browse the repository at this point in the history

  6. javadoc: fix erroneous tags

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    cce1a8b View commit details
    Browse the repository at this point in the history

  7. javadoc: fix more references

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    45e6571 View commit details
    Browse the repository at this point in the history

  8. javadoc: fix emphasize tags

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    35c2bc3 View commit details
    Browse the repository at this point in the history

  9. chore: fix missing javadoc errors

    @jdrueckert
    jdrueckert committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    60a41a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. javadoc: fix @see

    @jdrueckert
    jdrueckert committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3d13e1f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. checkstyle: remove illegal throws

    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    848947e View commit details
    Browse the repository at this point in the history

  2. checkstyle: remove unused imports

    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f585450 View commit details
    Browse the repository at this point in the history

  3. refactor: replace explicit close with try-with-resources

    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    01e8edd View commit details
    Browse the repository at this point in the history

  4. revert: removal of unused param from AbstractFamily constructor

    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b841271 View commit details
    Browse the repository at this point in the history

  5. revert: close zip Filesystem 

    - fails storage mananager tests -> needs to be investigated in more detail
    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2aad50f View commit details
    Browse the repository at this point in the history

  6. revert: removing required zip.close

    @jdrueckert
    jdrueckert committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    49725fa View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'develop' into chore/qaplug-findings

    @jdrueckert
    jdrueckert authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    bf26781 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Merge branch 'develop' into chore/qaplug-findings

    @jdrueckert
    jdrueckert authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    971c853 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Merge branch 'develop' into chore/qaplug-findings

    @jdrueckert
    jdrueckert authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    08bd7ea View commit details
    Browse the repository at this point in the history