refactor: fix gradle warnings #5140
Conversation
| val artifactView = resolvable.artifactView { | ||
| lenient(true) | ||
| } |
There was a problem hiding this comment.
I think these lines might have been here for their side-effect? It might be worth keeping them there if possible.
| @@ -43,7 +43,7 @@ plugins { | |||
| // For the "Build and run using: Intellij IDEA | Gradle" switch | |||
| id "org.jetbrains.gradle.plugin.idea-ext" version "1.0" | |||
|
|
|||
| id("com.google.protobuf") version "0.8.16" apply false | |||
| id("com.google.protobuf") version "0.9.4" apply false | |||
There was a problem hiding this comment.
Could this break network compatibility between game clients? I believe that protobuf is used for serialising entity data over the network.
| @@ -50,7 +50,7 @@ dependencies { | |||
| implementation("org.terasology.gestalt:gestalt-module:7.1.0") | |||
|
|
|||
| // plugins we configure | |||
| implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.1.3") | |||
| implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.1.3") // TODO: upgrade with gradle 7.x | |||
There was a problem hiding this comment.
We're on Gradle 8.3 now. I think this new comment is rather outdated already,
| @@ -4,7 +4,7 @@ | |||
| import java.net.URI | |||
|
|
|||
| plugins { | |||
| id("org.gradle.kotlin.kotlin-dsl") version "4.1.0" | |||
| id("org.gradle.kotlin.kotlin-dsl") version "4.0.14" | |||
There was a problem hiding this comment.
We stopped using an explicit version of the Kotlin DSL plugin after upgrading to Gradle 8.3. This might be a source of merge conflicts.
cherry picked PurityLakes pr MovingBlocks#5140 onto newest develop. kotlin plugin and spotbugs conflict comments are resolved by this. protobuf upgrade should be compabitle, at least according to documentation, so left it there. the lenient in module_deps.kt is again there: ``` val artifactView = resolvable.artifactView { lenient(true) } ```
cherry picked PurityLakes pr MovingBlocks#5140 onto newest develop. kotlin plugin and spotbugs conflict comments are resolved by this. protobuf upgrade should be compabitle, at least according to documentation, so left it there. the lenient in module_deps.kt is again there.
|
this pr could be closed now, as the commits got merged with #5153 . |
|
Good point. I'll close this. Thank you @PurityLake for starting this off. The changes were merged in (07176f7). |
Here is the PR again, sorry for taking so long