Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(TypeHandler): More tests for empty collections #5117

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

skaldarnar
Copy link
Member

Contains

This PR adds more tests to ensure that this is indeed the case.

Closes #2343.

Context

Our type handlers should be able to deserialize the empty array [ ]
corectly into different collection formats, for instance, basic
Arrays, collections like List<T>, or Map<K, V>.

How to Test

n/a, no code changes.

Outstanding before merging

n/a

Our type handlers should be able to deserialize the empty array `[ ]`
corectly into different collection formats, for instance, basic
`Array`s, collections like `List<T>`, or `Map<K, V>`.

This PR adds more tests to ensure that this is indeed the case.

Closes #2343.
@skaldarnar skaldarnar added Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Jul 12, 2023
@skaldarnar skaldarnar added this to the 2023 Revive - Milestone 1 milestone Jul 12, 2023
@skaldarnar skaldarnar merged commit 1d831ea into develop Jul 16, 2023
9 checks passed
@skaldarnar skaldarnar deleted the topic/tests-for-prefabs-with-empty-collections branch July 16, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Chore Request for or implementation of maintenance changes
Projects
Status: Done
Status: No status
Development

Successfully merging this pull request may close these issues.

Prefabs with empty lists cause failures - add support?
2 participants