refactor!: remove multi-world support #5116
Conversation
github-actions
bot
added
the
Type: Refactoring
|
@skaldarnar refactoring steps so far remove the option to add more than one world and removes respective code, in particular the former world lists are now only single WorldSetupWrappers... |
This removes UI widgest referencing the following translation keys: - `engine:menu#game-worlds` - `engine:menu#add` - `engine:menu#config`
skaldarnar
added
the
Topic: UI/UX
...e/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/UniverseSetupScreen.java
Outdated
Show resolved
Hide resolved
| @@ -242,4 +180,4 @@ | |||
| } | |||
| ] | |||
| } | |||
| } | |||
| } | |||
| @@ -291,6 +291,7 @@ private void initAssets() { | |||
| * in the drop-down. | |||
| * @return A list of world names encoded as a String | |||
| */ | |||
| @Deprecated | |||
| @@ -265,4 +263,4 @@ | |||
| } | |||
| ] | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
@skaldarnar your changes look fine to me.
can you also review the changes I did so we have a two-way approval?
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
where does this file come from? should it be committed?
There was a problem hiding this comment.
according to https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems it should be checked in 🤷
| @@ -70,19 +65,8 @@ public void initialise() { | |||
|
|
|||
| SimpleUri uri; | |||
| WorldInfo worldInfo; | |||
| //TODO: if we don't do that here, where do we do it? or does the world not show up in the game manifest? | |||
There was a problem hiding this comment.
This is done as part of GameManifestProvider#createGameManifest which is called on the other code paths, I think.
We can remove this TODO comment and the line below.
Contains
Remove code and abstractions related to mutli-word support during the "Advanced" game creation flow.
Context
The multi-world feature was added as a GSOC project back in 2018 by @TheFlash98. For more information, checkout the original forum post GSOC 2018 - Multiple Worlds or the project page.
While the world generation flow now supports to "create" multiple worlds and configure them separately, these multiple worlds were never experianceable in-game.
How to test
Create a new game via the "Advanced" game setup flow.
Outstanding before merging
WorldSetupWrappers in screen classesFollow-ups