Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove vr support #5112

Merged
merged 9 commits into from
Jul 9, 2023
Merged

refactor: remove vr support #5112

merged 9 commits into from
Jul 9, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Jul 9, 2023

Contains

Removes classes and code related to VR Support as part of the scope reduction for the 2023 revival efforts.

Removed classes:

  • OpenVRInput
  • OpenVRControllers
  • OpenVRStereoCamera
  • OpenVRProvider
  • OpenVRState
  • OpenVRUtils
  • ControllerListener

Adjustments (removed code paths and usages) in:

  • Terasology.java
  • StateInGame
  • WorldRendererImpl
  • LocalPlayerSystem
  • FirstPersonHeldItemMountPointComponent
  • RenderingConfig
  • Video Settings Menu
  • ModuleTestingEnvironment
  • IntegrationEnvironment

How to test

Brief description of how to test / confirm this PR before merging

  • Compile Terasology, verify that no build errors
  • Start Terasology and CoreGameplay, verify that starts properly
  • Check Video Settings Menu looks fine

Outstanding before merging

  • Discuss whether and potentially decide that we indeed want to remove VR support

Dependencies

Requires Terasology/CoreRendering#74 and Terasology/ModuleTestingEnvironment#77

@jdrueckert jdrueckert added Status: Needs Discussion Requires help discussing a reported issue or provided PR Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Size: S Small effort likely only affecting a single area and requiring little to no research Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Jul 9, 2023
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 1 milestone Jul 9, 2023
@jdrueckert jdrueckert self-assigned this Jul 9, 2023
@pollend
Copy link
Member

pollend commented Jul 9, 2023

vulkan has a KHR extension for multi-view. not sure if wgpu implement this but something we can explore much much later. just wanted to note this.

https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_multiview.html

@DarkWeird
Copy link
Contributor

vulkan has a KHR extension for multi-view. not sure if wgpu implement this but something we can explore much much later. just wanted to note this.

https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_multiview.html

@pollend
Just for note:
https://github.com/philpax/wgpu-openxr-example

Example for openxr (vr) + wgpu.
This example interesting in another way too - there exposes underlaying api of wgpu - you can take vulkan directly.

Wgpu have open issue about vr. Maybe.. it will closed when we returns to VR.

Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out fine!

jdrueckert added a commit to Terasology/ModuleTestingEnvironment that referenced this pull request Jul 9, 2023
jdrueckert added a commit to Terasology/CoreRendering that referenced this pull request Jul 9, 2023
@jdrueckert jdrueckert merged commit 324376a into develop Jul 9, 2023
@jdrueckert jdrueckert deleted the refactor/remove-vr-support branch July 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Status: Needs Discussion Requires help discussing a reported issue or provided PR Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants