Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document restrictions for BindButtonEvent #5079

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

skaldarnar
Copy link
Member

Contains

While working on Terasology/FlexiblePathfinding#8 we noticed that there seem to be issues with sending events extending from BindButtonEvent programmatically (without the physical button press).

To avoid any future confusion (or at least find the issue sooner) I'm adding a brief docstring to the class stating it's intended use and that one should NOT use it directly.

How to test

n/a

Outstanding before merging

n/a

@github-actions github-actions bot added the Category: Doc Requests, Issues and Changes targeting javadoc and module documentation label Nov 14, 2022
@skaldarnar skaldarnar added Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Size: S Small effort likely only affecting a single area and requiring little to no research labels Nov 14, 2022
@jdrueckert jdrueckert added the Type: Improvement Request for or addition/enhancement of a feature label Nov 14, 2022
@jdrueckert jdrueckert added this to the 5.4.0 milestone Nov 14, 2022
@jdrueckert jdrueckert merged commit f95b815 into develop Nov 26, 2022
@jdrueckert jdrueckert deleted the doc/warn-about-BindButtonEvent branch November 26, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Improvement Request for or addition/enhancement of a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants