Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify implementation in Assets to one-liners #5064

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

skaldarnar
Copy link
Member

There are only a few utility functions in Assets that use more than one line
of code. And even those can be simplified to fit into a single line by making
better use of the (functional) interfaces of Optional or by removing
unnecessary checks and early returns.

@skaldarnar skaldarnar added Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Aug 21, 2022
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these static functions rely on CoreRegistry, I think this entire class is slated for removal.

But in the meantime, this doesn't hurt.

@keturn keturn merged commit 2e90f83 into develop Aug 21, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants