test(StorageManager): Convert TTE tests to MTE #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
added
the
Category: Test/QA
keturn
force-pushed
the
test/5032/storageManagerMTE
branch
from
5e68228
to
c83f16d
Compare
jdrueckert
approved these changes
Sep 26, 2022
| } | ||
|
|
||
| @Test | ||
| @Order(1) | ||
| public void testGetUnstoredPlayerReturnsNewStor() { | ||
| PlayerStore store = esm.loadPlayerStore(PLAYER_ID); | ||
| public void testGetUnstoredPlayerReturnsNewStor(StorageManager esm) { |
There was a problem hiding this comment.
Why do we have to hand-over the StorageManager for every test case now?
There was a problem hiding this comment.
I removed some things from being fields on the test class. It was convenient to help get the tests passing one at a time, and it's consistent with how other code would get the storage manager from a Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5032
All the assertions are intact.
One thing I skipped is setting up a RecordAndReplaySerializer for the StorageManager. I left the RecordAndReplay fields there to not add more renaming-noise to this PR than necessary, but they all stay
null.I'm okay with leaving R&R out. This test case has no assertions that are specific to R&R functionality, and it's optional to StorageManager.