security: upgrade dependencies #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, plexus-utils, protobuf-java, dom4j Things where Checkmarx flagged known CVEs in old versions. For the engine.telemetry changes, see https://docs.snowplowanalytics.com/docs/collecting-data/collecting-from-own-applications/java-tracker/migration-guide-v0-12/ > `bufferSize` has been renamed `batchSize` > `requestCallback()` is gone, since events that fail to send will now be automatically retried.
keturn
added
Category: Security
keturn
commented
May 22, 2022
engine/src/main/java/org/terasology/engine/config/flexible/constraints/StringConstraint.java
Show resolved
Hide resolved
…ades # Conflicts: # engine-tests/build.gradle # subsystems/DiscordRPC/build.gradle.kts
jdrueckert
reviewed
May 26, 2022
engine/src/main/java/org/terasology/engine/config/flexible/constraints/StringConstraint.java
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/telemetry/TelemetryEmitter.java
Show resolved
Hide resolved
|
btw, I don't even know if the snowplow stuff still worked before - IIRC we had a [G|T]SoC project a while ago that revived the logging stack, but the time didn't suffice to do the same for the metrics stack. |
We don't need to exclude or constrain it if we never ask for it in the first place! build-logic does still contain reflection-manifest code, but it uses the JSON serializer, not XML.
jdrueckert
approved these changes
May 28, 2022
jdrueckert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things where Checkmarx flagged known CVEs in old versions. That's why I've tagged it "security," but I don't know if any of these things are actually exploitable by someone who doesn't already have trusted access.
For the engine.telemetry changes, see
https://docs.snowplowanalytics.com/docs/collecting-data/collecting-from-own-applications/java-tracker/migration-guide-v0-12/
How to test
Brief description of how to test / confirm this PR before merging
Anyone know how to test the Snowplow stuff in
engine.telemetry?