Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for skinned Mesh #4968

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pollend
Copy link
Member

@pollend pollend commented Nov 30, 2021

implement skinned mesh for animations :D. all this is done on the gpu and should be significantly faster then updating all the vertex data on the CPU and pushing the mesh data over to the GPU. I keep the old skeletalMesh so we can support both and also address the problems with the original skeletalMesh. I would like to get rid of the offset and ensure the animations stay in sync with the bone animations. i.e if you parent an object to an existing bone entity then I expect it to stay in the correct location. All this does is add the new type without affecting the original.

@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Nov 30, 2021
pollend added a commit to Terasology/WildAnimals that referenced this pull request Nov 30, 2021
@pollend
Copy link
Member Author

pollend commented Nov 30, 2021

@pollend
Copy link
Member Author

pollend commented Dec 5, 2021

so I simplified the API a lot you set the animation and the current time of the animation. The old behavior could be managed through a legacy component until we work out something better. The details to how the animation are left up to the implementation :D. This is less opinionated but should let us do a lot more 👯

Squashed commit of the following:

commit 5fd46e2
Author: Michael Pollind <mpollind@gmail.com>
Date:   Mon Nov 29 17:54:39 2021 -0800

    chore: update to skinned mesh

commit 06f2189
Author: Michael Pollind <mpollind@gmail.com>
Date:   Mon Nov 29 12:11:06 2021 -0800

    feat: add skinned mesh Material

commit 63d817a
Author: Michael Pollind <mpollind@gmail.com>
Date:   Sun Nov 28 23:11:04 2021 -0800

    feat: replace skeletalMesh with skinnedMesh

commit 67bd3bf
Author: Michael Pollind <mpollind@gmail.com>
Date:   Sun Nov 28 21:02:39 2021 -0800

    feat: implement skinned mesh
@pollend pollend force-pushed the feature/implement-skinnedMesh-1 branch from 8b217d4 to 103a873 Compare April 10, 2022 19:42
@pollend pollend force-pushed the feature/implement-skinnedMesh-1 branch from 8d818c2 to 6b60fbe Compare May 12, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant