Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated method in Block #4965

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Nov 27, 2021

There are a few more instance of Tessellator this removes the usage of getMesh() for block. The standalone mesh can pulled from the meshGenerator. There is a strict precondition for meshGenerator that prevents it from every being null so the null condition can't happen.

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Nov 27, 2021
@pollend pollend force-pushed the chore/remove-deprecated-method-Block branch from 79c0bbb to d9290ec Compare November 27, 2021 19:52
pollend added a commit to Terasology/Books that referenced this pull request Nov 27, 2021
pollend added a commit to Terasology/Journal that referenced this pull request Nov 27, 2021
pollend added a commit to Terasology/Kallisti that referenced this pull request Nov 27, 2021
pollend added a commit to Terasology/WorkstationCrafting that referenced this pull request Nov 27, 2021
pollend added a commit to Terasology/WorldlyTooltip that referenced this pull request Nov 27, 2021
@DarkWeird
Copy link
Contributor

DarkWeird commented Nov 29, 2021

nitpick: suggest to fix javadoc for setMeshGenerator.. it cannot to handle receive null

@DarkWeird DarkWeird merged commit 71a98a1 into develop Dec 15, 2021
@DarkWeird DarkWeird deleted the chore/remove-deprecated-method-Block branch December 15, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants