chore: remove usage of Tesselator for BlockSelectionRenderer #4964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
skaldarnar
approved these changes
Dec 4, 2021
There was a problem hiding this comment.
Tested out fine, looks the same as before.
I'm not a huge fan of code duplication, but if that helps you maintaining this code then let's go for it.
Maybe it is even a good thing that they don't use the same code anymore to encourage visual changes/differences between regular block selection, bounding boxes, and other things.
pollend
deleted the
feat/remove-usage-Tesselator-BlockSelection-Renderer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces the usage of the Tesslator with just the direct MeshData. There is some similar code in IconMeshFactory, and BoundingBoxRenderer. I've ommited things with regards to constructing the mesh and there are some slight detail differences where a unified API ends up becoming more of a burden. Its not much more code from what I can tell and its clear enough that the duplication does not seem too bad to me.