-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(headless-execution): MainMenuState can handle headless now. Correct loadingstate for headless clients. #4962
Conversation
…ct loadingstate for headless clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but yeah, let's be sure to test before merging.
engine/src/main/java/org/terasology/engine/core/modes/StateMainMenu.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateMainMenu.java
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateMainMenu.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests out fine in singleplayer and multiplayer (host, join) on both headed and headless
I ran some MTE tests. Can confirm that throwing the exception there makes the message stand out better in some tests. I'll re-run some of these to figure out if their failures are related to this branch or not. |
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After re-running those MTE tests, it didn't seem like their problems were particular to this branch.
Contains
How to test
Run Terasology in:
./gradlew server
)