Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headless-execution): MainMenuState can handle headless now. Correct loadingstate for headless clients. #4962

Merged
merged 5 commits into from
Nov 29, 2021
Merged

fix(headless-execution): MainMenuState can handle headless now. Correct loadingstate for headless clients. #4962

merged 5 commits into from
Nov 29, 2021

Conversation

DarkWeird
Copy link
Contributor

Contains

  • Support for headless client in LoadingState.
  • MainMenuState handles headless too.

MTE's client not working yet. There needs to revisit @RegisterSystem#value (RegisterMode)
engine don't support headless clients at Systems level.. needs to separate Systems which handles GUI and Systems which handles client logic.

How to test

Run Terasology in:

  1. SinglePlayer
  2. Join Game
  3. Host Game
  4. Dedicated server (./gradlew server)

@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Nov 22, 2021
keturn
keturn reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but yeah, let's be sure to test before merging.

engine/src/main/java/org/terasology/engine/core/modes/StateMainMenu.java Outdated Show resolved Hide resolved
engine/src/main/java/org/terasology/engine/core/modes/StateMainMenu.java Show resolved Hide resolved
@keturn keturn mentioned this pull request Nov 22, 2021
Open
jdrueckert
jdrueckert reviewed Nov 27, 2021
View reviewed changes
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out fine in singleplayer and multiplayer (host, join) on both headed and headless

@jdrueckert jdrueckert mentioned this pull request Nov 27, 2021
Open
@keturn
Copy link
Member

keturn commented Nov 27, 2021

I ran some MTE tests. Can confirm that throwing the exception there makes the message stand out better in some tests.

I'll re-run some of these to figure out if their failures are related to this branch or not.

@keturn @jdrueckert
chore(StateMainMenu): wording of failure message
8e65a86 
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
keturn
keturn approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After re-running those MTE tests, it didn't seem like their problems were particular to this branch.

@keturn keturn merged commit 269f2b0 into develop Nov 29, 2021
@keturn keturn deleted the fix/fix-headless-fall-to-headed-mainmenu branch November 29, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert left review comments

@keturn keturn keturn approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkWeird @keturn @jdrueckert