feat(i18n): Update engine settings i18n #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzats
added
the
Topic: UI/UX
|
@rzats ! Now that's a name it is nice to see again. Welcome back 👋 |
|
Thanks @Cervator! (I still do a little lurking on Discord every now and then 👀) |
DarkWeird
requested changes
Nov 23, 2021
There was a problem hiding this comment.
This PR break English Language.
10:23:18.705 [main] ERROR o.t.gestalt.assets.AssetType - Failed to load asset 'engine:menu_en'
java.io.IOException: Could not parse file 'menu_en.lang'
at org.terasology.engine.i18n.assets.TranslationFormat.load(TranslationFormat.java:100)
at org.terasology.engine.i18n.assets.TranslationFormat.load(TranslationFormat.java:38)
....
Caused by: com.google.gson.JsonSyntaxException: duplicate key: settings-language
at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:190)
...
funny fact: breaking entry - Language
Ukrainian works in described place.
| "settings-chunk-timeout": "Chunk generation fail timeout (ms)", | ||
| "settings-chunks-till-save": "Max unloaded chunks percentage till save", | ||
| "settings-debug-mode": "Debug mode", | ||
| "settings-language": "Language", |
There was a problem hiding this comment.
Duplicate entry.
see Line 356
There was a problem hiding this comment.
Fixed this and the merge conflict!
DarkWeird
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
A few strings in the core engine are currently untranslated - these are mostly found in the new autoconfig, as well as other settings. This fixes them to be properly i18n-able!
How to test
Browse around the settings menu to see if everything looks OK.
Outstanding before merging
None!