-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade minimum compatible version to Java 11 #4928
Conversation
Build passed its unit tests, but crashed during the javadoc task? That's certainly not what I expected. Maybe I didn't put enough RAM in the pod configuration? (Yet unknown if integration tests pass, because that stage only runs after javadoc completes.) |
|
The LGTM service has a Java 8 build environment. There's been no news posted to their blog since they were acquired by GitHub two years ago. Would we be okay with dropping the LGTM GitHub integration? |
I really expected to run in to the #3992 failure at this point, but it looks like all the tests are passing in this run, so hooray? |
wait, I do get that failure locally. 😕 |
I think we have not been running the TypeHandlerLibrary tests ever since the unitTest / integrationTest split 😢 |
This updates the project's gradle configuration to use the Java 11 compatibility level. IntelliJ IDEA will recognize this configuration when determining which languages features are available.
Requires
CI must have a Java 11 environment to build in before we have developers making commits for Java 11.