Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headless-fixes): remove InputSystem and NuiManager from headlesses #4907

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

DarkWeird
Copy link
Contributor

Contains

Removes InputSystem exception from headless
Fixes #4481
Fixes #3793
Removes NuiManager from headless. (yahoo ! no more screens and jpgs at headless mode - MTE, Server, headless client)

How to test

Try game in 4 modes:

  1. Server(Headless)
  2. Host game(from main menu)
  3. Connect to server(can reuse 1)
  4. Singleplayer

You should:
0. enter

  1. play a bit
  2. exit as usually

@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Sep 13, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2021

This pull request introduces 1 alert when merging 0fc2540 into 01d6c88 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not awake enough to merge this at the moment, but I am hopeful. It should help the speed and signal/noise ratio in MTE tests a lot.

@keturn keturn self-requested a review September 13, 2021 16:32
@jdrueckert jdrueckert added the Status: Needs Testing Requires to be tested in-game for reproducibility label Sep 14, 2021
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I can't properly test this until I'm back from vacation. But I left some code-wise review comments at least.

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 1 alert when merging c16ebef into 01d6c88 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as suggested in the PR description. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Testing Requires to be tested in-game for reproducibility Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
3 participants