Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: migrate deprecated texture2D #4892

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Sep 5, 2021

found we have some old references for texture2D

13:14:24.593 [main] WARN  o.t.e.rendering.opengl.GLSLShader - Shader 'CoreRendering:chunk' failed to compile for features '[]'.
Game output: 
Game output: Shader Info: 
Game output: ERROR: 0:506: Invalid call of undeclared identifier 'texture2D'
Game output: ERROR: 0:509: Use of undeclared identifier 'maskColor'

ref: Terasology/CoreRendering#72

@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Sep 5, 2021
@keturn
Copy link
Member

keturn commented Sep 6, 2021

I get an error with the splashscreen, which doesn't close and it's showing uninitialized memory.

Exception in thread "splashscreen-loop" java.lang.RuntimeException: 0(9) : error C7532: global function texture requires "#version 130" or later

	at org.terasology.splash.glfw.graphics.Shader.checkStatus(Shader.java:87)
	at org.terasology.splash.glfw.graphics.Shader.compile(Shader.java:78)
	at org.terasology.splash.glfw.graphics.Shader.createShader(Shader.java:119)
	at org.terasology.splash.glfw.graphics.Shader.loadShader(Shader.java:146)
	at org.terasology.splash.glfw.graphics.Renderer.setupShaderProgram(Renderer.java:408)
	at org.terasology.splash.glfw.graphics.Renderer.init(Renderer.java:77)
	at org.terasology.engine.GLFWSplashScreen.run(GLFWSplashScreen.java:103)
	at java.base/java.lang.Thread.run(Thread.java:829)

@pollend
Copy link
Member Author

pollend commented Sep 6, 2021

I get an error with the splashscreen, which doesn't close and it's showing uninitialized memory.

Exception in thread "splashscreen-loop" java.lang.RuntimeException: 0(9) : error C7532: global function texture requires "#version 130" or later

	at org.terasology.splash.glfw.graphics.Shader.checkStatus(Shader.java:87)
	at org.terasology.splash.glfw.graphics.Shader.compile(Shader.java:78)
	at org.terasology.splash.glfw.graphics.Shader.createShader(Shader.java:119)
	at org.terasology.splash.glfw.graphics.Shader.loadShader(Shader.java:146)
	at org.terasology.splash.glfw.graphics.Renderer.setupShaderProgram(Renderer.java:408)
	at org.terasology.splash.glfw.graphics.Renderer.init(Renderer.java:77)
	at org.terasology.engine.GLFWSplashScreen.run(GLFWSplashScreen.java:103)
	at java.base/java.lang.Thread.run(Thread.java:829)

looks like I forgot to add this to the header: #version 330 core

@pollend pollend requested a review from keturn September 6, 2021 19:42
@pollend
Copy link
Member Author

pollend commented Sep 6, 2021

@keturn needed to update the version to compile the shader

Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that fixed the splashscreen. 👍

@keturn keturn merged commit f85be6d into develop Sep 6, 2021
@keturn keturn deleted the chore/migrate-deprecated-texture2d branch September 6, 2021 22:52
@pollend pollend added this to the v5.2.0 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants