chore: remove deprecated Chunk#getPosition(Vector3i)

[pollend]

we've had this method depreacted for a while in Chunk, I made sure to have the Vector3i that's allocated in Chunk fixed in place so once allocated we won't be able to modify the position of a chunk. do you think we should be a bit more defensive @keturn :?

[keturn]

Why are so many of the calls to chunk.getPosition() wrapped in new Vector3i?

Maybe that's related to your question about how defensive the code needs to be, but I'm not quite connecting the dots.

[skaldarnar]

I think we should add to the description in

Terasology/engine/src/main/java/org/terasology/engine/world/chunks/Chunk.java

Lines 25 to 28 in f85be6d

	/**
	* @return Position of the chunk in world, where units of distance from origin are chunks
	*/
	Vector3ic getPosition();

that the resulting vector can be considered stable/constant for a given chunk (at least we are using it that way).

Also, I'm wondering whether some of the new Vector3i(...) allocations are just because some other API demands to pass in a mutable Vector3i instead of a immutable Vecor3ic.
Where possible, we should fix those APIs to work with the immutable type instead. We can likely do that in smaller batches and thereby make better use of Chunk#getPosition().

[skaldarnar]

Hm, we often recommend to create a copy when storing vectors in a map, but I guess for chunk position it is fine to assume the position to be constant and stable for a chunk, not changing ever. 🤔

[jdrueckert]

@pollend care to answer @keturn's questions above? 🙃

[pollend]

@pollend care to answer @keturn's questions above? upside_down_face

umm, I'm guessing its defensive programming. I'll have a look later tonight.

[pollend]

Why are so many of the calls to chunk.getPosition() wrapped in new Vector3i?

Maybe that's related to your question about how defensive the code needs to be, but I'm not quite connecting the dots.

those shouldn't be wrapped in a new

[keturn]

This does look much better without the extra new Vectors. 👍 Just once left I wasn't sure about.

I noticed a signature change on fireChunkTessellated, but it looks like there's only one call site for that and it did get updated, so that part seems good too.

[keturn]

Currently being held by CI for some unused code checks. I recommend turning on IntelliJ's “optimize imports on the fly“ setting—or, if you don't like it doing stuff on the fly, at least the “optimize imports“ option in the “before commit“ section.