Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove internal ai system for engine #4878

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Aug 31, 2021

This code is only used within the portal module I think we have other things that can easily replace this logic. need to review the impact and see what can be changed with the portal module. probably have something that can replicate the behavior we are looking for or potentially just shoveling this code into Spwaning?

I was looking at the Spawning module and it references Portals and then dead ends so its not referenced to any other modules. might be worth just dropping them from omega.

Depends on Terasology/Spawning#9

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Aug 31, 2021
@skaldarnar skaldarnar added the Topic: AI Requests, Issues and Changes related to pathfinding, behaviors, etc. label Sep 1, 2021
@skaldarnar
Copy link
Member

skaldarnar commented Sep 1, 2021

I'm always a fan of removing code 🙃

For completeness, I'm pinging

  • @Cervator as main author of Portals (I think)
  • @casals as main driving force of AI topics
  • (@jdrueckert @keturn as you may have looked at Spawning over the summer and usually have some opinion about adding/removing modules from Omega)

@casals
Copy link
Contributor

casals commented Sep 1, 2021

Not sure if it's only a matter of transferring it to Spawning but yes, absolutely. As long as the dependencies are solved (just checking a full distribution should be enough), aye.

@pollend
Copy link
Member Author

pollend commented Sep 2, 2021

I would opt to move Portals and Spawnable to archive and maybe salvage the code for something else. @skaldarnar

@jdrueckert
Copy link
Member

@pollend I created Terasology/Spawning#9 to make omega compile with this PR here. Spawning is currently still part of omega and the least we should do is keep it compiling. Even if we remove it from omega soon, as one of the modules that are hopefully finding their way back sooner than later, we should keep it in a good state as we can without investing too much resources - and just moving the files you remove here into there really wasn't much of an effort, it just needed to be done.

I'd appreciate a review on Terasology/Spawning#9 so we can get this PR here merged, too.

@jdrueckert jdrueckert merged commit 108a64d into develop Oct 11, 2021
@jdrueckert jdrueckert deleted the chore/remove-engine-internal-ai-system branch October 11, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: AI Requests, Issues and Changes related to pathfinding, behaviors, etc. Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants