chore: remove SubmersibleCamera abstraction #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
pollend
added
the
Type: Refactoring
jdrueckert
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SubmsersibleCamera abstraction seems to complicate things a lot so I just did away with the abstraction. I think this should help with readability. the use case is limited and the abstract is backward since it goes from camera --> submersible but all cameras are considered submersible cameras just simpler to do away with this. submersible is pretty limited in its use case so I just moved that logic to CoreRendering. you need to merge this PR: Terasology/CoreRendering#71 before this one. the PR in core rendering can be merged without this once since I just swap the base class to Camera.
Not sure I agree with the propertychange stuff from cameraconfig not all cameras are dependent on the resolution nor are all cameras dependent on the view distance or LOD. for the variance shadow maps I would like to tune the z-distance to best fit the camera frustrum.