Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stop ignoring checkstyle findings #4864

Merged
merged 10 commits into from
Aug 27, 2021
Merged

chore: stop ignoring checkstyle findings #4864

merged 10 commits into from
Aug 27, 2021

Conversation

jdrueckert
Copy link
Member

No description provided.

@jdrueckert jdrueckert added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Type: Chore Request for or implementation of maintenance changes labels Aug 22, 2021
@jdrueckert jdrueckert self-assigned this Aug 22, 2021
@keturn keturn self-requested a review August 23, 2021 01:04
@jdrueckert
Copy link
Member Author

Fix Checkstyle Findings

keturn
keturn approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to make those fields in facade private to match all the others, rather than re-order them based on their accessibility.

@keturn keturn merged commit 66264a8 into develop Aug 27, 2021
@keturn keturn deleted the chore/stop-ignoring-checkstyle-findings branch August 27, 2021 17:28
@keturn keturn added this to the v5.2.0 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keturn keturn keturn approved these changes

@skaldarnar skaldarnar Awaiting requested review from skaldarnar

Assignees

@jdrueckert jdrueckert

Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @keturn