fix: Better handling of ComponentSystem loading with optional dependencies #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Build/CI
skaldarnar
reviewed
Aug 13, 2021
There was a problem hiding this comment.
Ah, I see - if we cannot meet all requirements a system has we skip it - so if we have one big system depending on 5 optional modules it won't load if any of those is missing.
To improve the situation, we split systems such that they have high cohesion w.r.t. to the modules they (optionally) depend on.
Will test later today, but the changes look reasonable to me and I think make it better understandable, even if not a perfect solution for the underlying problem...
engine/src/main/java/org/terasology/engine/core/ComponentSystemManager.java
Outdated
Show resolved
Hide resolved
…mManager.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
skaldarnar
approved these changes
Aug 13, 2021
skaldarnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
How to test
Start JS with optional dependencies: