refactor(GameScheduler): provide ThreadMonitor-compatible schedule method #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Refactoring
keturn
added
the
Topic: Concurrency
pollend
reviewed
Aug 10, 2021
Comment on lines
103
to
+112
|
|
||
| Runnable task; | ||
| if (savingGamePreview) { | ||
| GameScheduler.parallel().schedule(() -> saveGamePreviewTask(buffer, width, height)); | ||
| task = () -> saveGamePreviewTask(buffer, width, height); | ||
| this.savingGamePreview = false; | ||
| } else { | ||
| GameScheduler.parallel().schedule(() -> saveScreenshotTask(buffer, width, height)); | ||
| task = () -> saveScreenshotTask(buffer, width, height); | ||
| } | ||
|
|
||
| GameScheduler.scheduleParallel("Write screenshot", task); |
There was a problem hiding this comment.
would probably still opt to just use two calls to scheduleParallel. no need to be clever.
pollend
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal in hopes of moving us past the controversial point on #4799. It targets that PR's branch.
This is not a rejection of micrometer. Using micrometer instead of some of our homegrown meters is a welcome plan! But I don't think we need to do it in that PR.