Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deprecate WorldProvidingHeadlessEnvironment #4830

Merged
merged 2 commits into from
Jul 27, 2021
Merged

test: deprecate WorldProvidingHeadlessEnvironment #4830

merged 2 commits into from
Jul 27, 2021

Conversation

keturn
Copy link
Member

@keturn keturn commented Jul 26, 2021

  • Make TerasologyTestingEnvironment internal. It's still widely used in the engine tests, but we don't need to export it to modules.
  • Deprecate WorldProvidingHeadlessEnvironment. (There is still some utility code using it in Behaviors and Pathfinding, so we can't yet delete it.)
    • That means Environment and HeadlessEnvironment can't be removed from the package, but we can add a note directing module maintainers to MTE.

@keturn
test: deprecate WorldProvidingHeadlessEnvironment
c695540 
- Make TerasologyTestingEnvironment internal. It's still widely used in the engine tests, but we don't need to export it to modules.
- Deprecate WorldProvidingHeadlessEnvironment. (There is still some utility code using it in Behaviors and Pathfinding, so we can't yet delete it.)
  - That means Environment and HeadlessEnvironment can't be removed from the package, but we can add a note directing module maintainers to MTE.
@keturn keturn added Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research labels Jul 26, 2021
@keturn
Copy link
Member Author

keturn commented Jul 26, 2021

Note that most of the usages seen in https://github.com/search?q=org%3ATerasology+WorldProvidingHeadlessEnvironment&type=code are addressed by Terasology-Archived/Pathfinding#64

@keturn keturn merged commit b89eda8 into develop Jul 27, 2021
@keturn keturn deleted the test/deprecateHeadlessEnvironment branch July 27, 2021 14:26
@keturn keturn added this to the v5.1.0 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pollend pollend pollend approved these changes

Assignees
No one assigned
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keturn @pollend