chore: remove finite check from LocalPlayer #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/remove-checks-LocalPlayer
github-actions
bot
added
the
Type: Chore
…re/remove-checks-LocalPlayer
…ocks/Terasology into chore/remove-checks-LocalPlayer
…re/remove-checks-LocalPlayer
|
want to test this with multiplayer but I think I've mostly addressed the broken cases |
jdrueckert
approved these changes
Oct 5, 2021
|
Tested with local (non-headless) multiplayer. Normal LocalPlayer behavior didn't seem to be negatively impacted by this change. |
keturn
added a commit
that referenced
this pull request
May 10, 2022
Restores the alternate behavior described in the docstring, correcting a regression introduced in #4795. This "LocalPlayer without camera" situation has come up in headless MTE tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've mentioned in the past having a situation where the player position is placed at (0,0,0). I'm suspecting it has something to do with this logic. so for an invalid position we just return dest or a new Vector3/Quaternion. we shouldn't be just defaulting to 0,0,0. this ends up hiding a larger underlying problem where we see some odd behavior but we've written this logic in a way to hide a large problem. I rather have the game crash with a stacktrace then try poking at thing in the dark because we've written ourselves into a corner.
#4152 #4662