-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move SideBitFlags into Side #4768
Conversation
The side bit flag is used in many places. Do you plan to migrate those in follow-up PRs, and if so, could you please create them for the Omega line-up? I think merging |
…re/move-SideBitFlags-into-Side
…Blocks/Terasology into chore/move-SideBitFlags-into-Side
@skaldarnar it doesn't need to happen immediately the old interface is still there. |
I know, and I think the benefit here is that we are not blocked by this migration even while it's happening, and that we are also not forced to do everything at once. However, with just this PR and no follow ups, we just created a second option where there was only one before, with no examples on how to use it or to motivate why the "new" implementation is better than the old one. Therefore, I'd like to repeat my request to at least start making the according PRs such that we can get this finished (i.e., remove |
…Blocks/Terasology into chore/move-SideBitFlags-into-Side
Deprecate most of
SideBitFlag
and offer direct replacements inSide
, basically merging the two classes.Respective replacements are documented in the deprecation docstring.
This prepares for eventually removing
SideBitFlag
.