refactor(rendering)!: migrate chunk vertex attribute changes #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Refactoring
pollend
changed the title
pollend
added a commit
to Terasology/CoreRendering
that referenced
this pull request
May 31, 2021
|
so this should be a first pass on this logic. we probably want to tweak this more. |
…ks/Terasology into refactor/rendering-migrate-chunk-vertex-attribute
|
here is how I get this to work under renderdoc I've just been building the project in intellij and executing
|
Cervator
added
the
Topic: Rendering
jdrueckert
reviewed
May 31, 2021
Comment on lines
90
to
92
| //bool checkFlag(int flag, float val) { | ||
| // return val > float(flag) - 0.5 && val < float(flag) + 0.5; | ||
| //} |
There was a problem hiding this comment.
if we don't use this anymore, can we remove it?
Comment on lines
33
to
35
| //bool checkFlag(uint flag, uint val) { | ||
| // return flag == val; | ||
| //} |
|
|
||
| #if defined (NORMAL_MAPPING) | ||
| normalMatrix = gl_NormalMatrix; | ||
| worldSpaceNormal = gl_Normal; | ||
| // normalMatrix = in_normal; |
Comment on lines
127
to
129
| vertexWorldPos = in_vert + chunkPositionWorld.xyz; | ||
|
|
||
| if (in_frames > 0) { |
Comment on lines
138
to
140
| sunVecView = (modelViewMatrix * vec4(sunVec.x, sunVec.y, sunVec.z, 0.0)).xyz; | ||
|
|
||
| isUpside = in_normal.y > 0.9 ? 1 : 0; |
Comment on lines
+13
to
+14
| gl_Position = projectionMatrix * modelViewMatrix * vec4(in_vert, 1.0); | ||
| v_pos = gl_Position; |
| varying vec3 worldSpaceNormal; | ||
| varying mat3 normalMatrix; | ||
| out vec3 worldSpaceNormal; | ||
| //out mat3 normalMatrix; |
| public final VertexAttributeBinding<Vector3fc, Vector3f> position; | ||
| public final VertexAttributeBinding<Vector3fc, Vector3f> normals; | ||
| public final VertexAttributeBinding<Vector2fc, Vector2f> uv0; | ||
| // public final VertexAttributeBinding<Colorc, Color> color; // color data is unused |
There was a problem hiding this comment.
I want to keep a note here because we had color data that we're not using. I guess the plan was to have colored lights of some kind :?
There was a problem hiding this comment.
There were beautiful colored torches long ago, in either case. This might have been left in place by somebody disabling them "temporarily" hoping they'd be back?
jdrueckert
approved these changes
May 31, 2021
|
here is how I get this to work under renderdoc I've just been building the project in intellij and executing
|
pollend
added a commit
to Terasology/CoreRendering
that referenced
this pull request
Jun 5, 2021
* refactor(rendering)!: update chunk rendering logic with changes PR: MovingBlocks/Terasology#4735 * chore: clean up states changes in chunkmesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates chunkMesh to take advantage of this attribute scheme. I also migrated the code to take advantage of GLSL 330. There isn't really any significant performance changes from what I can tell. one nice thing about this change is that renderdoc is able to properly render frames from the game with debug information about incoming vertices and different state of the rendering peipline. should make it easier to debug our render pipeline.
PR: Terasology/CoreRendering#59
looks like we don't really take good advantage of the depth pass well. most of the texture is unused from what I can tell.
