Don't move the camera when window is refocused #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
reviewed
Mar 20, 2021
engine/src/main/java/org/terasology/engine/input/lwjgl/LwjglMouseDevice.java
Outdated
Show resolved
Hide resolved
keturn
suggested changes
Mar 20, 2021
pollend
requested changes
Mar 21, 2021
Comment on lines
+130
to
+131
| xpos = mouseX.get(0); | ||
| ypos = mouseY.get(0); |
There was a problem hiding this comment.
can this be replaced with a Vector2d;
There was a problem hiding this comment.
Yes, it can. That does make it shorter, as long as we're fine with newPos.sub(pos, posDelta) being somewhat harder to read than xposDelta = x - this.xpos.
There was a problem hiding this comment.
It would also require corresponding changes to the update method which uses those fields.
I know I've encouraged a bit of scope creep here by bringing up the code duplication in update and the use of rewind, but we should probably not stack all of the possible clean-ups we can think of in to this bugfix PR.
keturn
approved these changes
Mar 21, 2021
skaldarnar
approved these changes
Mar 25, 2021
pollend
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Fix the camera position resetting to look at the sky when the window is unfocused and then focused again. It just resets the mouse position whenever the window is focused, which also means that if you unfocus, move the mouse, and focus again, the camera doesn't move.
How to test
Start the game, move the camera, alt-tab to another window, then alt-tab back. The camera shouldn't move.