fix(rendering): clipping plane on LoD 0 #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS-Soundwave
approved these changes
Feb 19, 2021
skaldarnar
added
Topic: Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a black something in the center of my screen after setting LoD from 10 to 0. Seemed to be on the "back plane" as it disappeared behind loaded chunks. When setting LoD to 1, it didn't show anymore.
@PS-Soundwave assumed that the far clipping plane might be pulled in too far on lowest LoD and suggested this quickfix. Turned out fine, although there seems to be a larger issue, that @PS-Soundwave plans to write up (please also link it here) and investigate 👍
Co-authored-by: Soundwave PS-Soundwave@users.noreply.github.com