-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(PC): remove unused tasks for running headless server from source #4463
Conversation
Cervator clarifies:
|
cc7ee02
to
0ffa67d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to leave the server
exec task intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay less mess! One bonus comment left that would be an enhancement, previously to test headless via Gradle we'd either need to tweak something manually ahead of time or start the server once, edit the generated config.cfg
and restart.
// TODO: Make a task to reset server / game data | ||
tasks.register<RunTerasology>("server") { | ||
description = "Starts a headless multiplayer server with data stored in [project-root]/$localServerDataPath" | ||
dependsOn("setupServerConfig") | ||
dependsOn("setupServerModules") | ||
args("-headless", "-homedir=$localServerDataPath") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add -overrideDefaultConfig=override.cfg
here to match the headless run config for IntelliJ 👍
In the PC facade build config, removes tasks
server
,setupServerModules
,setupServerConfig
at the suggestion of #4454 (comment)Those setup tasks have a significant amount of code so removing them will slim the build config down considerably.