feat: Remove weird features near the origin from BrownianNoise #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
approved these changes
Nov 28, 2020
jdrueckert
approved these changes
Nov 28, 2020
jdrueckert
changed the title
Cervator
added
the
Category: Gameplay Content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrownianNoise works by adding several scaled copies of the same base noise function together. Generally this works well, but it can lead to weird features at the origin, where all of the copies are aligned (the value at the origin in always 0, and it tends to have a very large gradient there). This PR fixes that, by shifting each of the copies by random amounts relative to each other. This has the effect that the spawn point is no longer always on a biome boundary and surrounded by cliffs.
I've gotten so used to the usual surrounded-by-cliffs style of spawn plateau that I don't usually notice how weird it is, but when I tested this PR, this is the spawn plateau I got:
