-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(settings): disable identity service login ui features #4125
Conversation
…overriding of child enabled property during initialization by UIBox, modified UIFormat to process enabled field after Layout content initialization, disabled Identity Service Login features in UI
Thanks for the PR @Ankhell ! I hope you don't mind hanging on for just a bit, we're in the middle of extracting our UI system this weekend (and maybe a bit longer) which might mean this change would have to be replicated / moved to its new repo https://github.com/MovingBlocks/TeraNUI and specifically its v1.x branch. Will get to this as soon as otherwise able :-) |
Alright, TeraNUI is officially live! #4017 has been merged. @Ankhell would you be up for replicating this change in a PR made against https://github.com/MovingBlocks/TeraNUI/tree/release/v1.x ? It should be about the same code. You can re-embed the TeraNUI source into a game engine workspace with If any questions feel free to hop on Discord for live chat sometime! |
@Cervator Sure thing I would do that as soon as I would have some spare time (: |
the relevant code for this has been moved to this module: @Ankhell https://github.com/MovingBlocks/TeraNUI |
Hi @Ankhell, quickly checking in: What do you think when you'll find "some spare time"? 🙃 More like this week / this month / next month / before the end of the year? |
I'm terribly sorry for being lost, moved AbstactWidget part to TeraNUI MovingBlocks/TeraNUI#28 and left everything else here, hope that's what I was supposed to do |
@Ankhell Thanks for the update and the PR on TeraNUI! |
@jdrueckert moved PR to the correct branch MovingBlocks/TeraNUI#29 |
All good with the new branch, thanks @Ankhell 👍 @jdrueckert I don't know cherry pick well enough to really have an idea if it'll work well in both directions. I get the feeling Git will probably be able to recognize the same commits, but am less sure how much hassle it would be for us to catch all the commits to cherry pick. No worries on this change for now at least :-) |
So I finally got to try this out (naturally in combination with MovingBlocks/TeraNUI#29). However, I found that the main menu UI still shows elements related to the identity storage service: @Ankhell Did I misunderstand the intended effect of the PR? I thought these UI features were to be removed by your PR? Please correct me if I'm wrong 😅 |
@jdrueckert according to the name of this issue #4104 it was necessary to disable that part of UI, not to remove it, am I right, @skaldarnar ? |
@Ankhell As skal is currently sitting behind the wheel (at 200 km/h ^^) let me answer this: The identity Server currently doesn't work. That's why we don't want it to be visible to the users at the moment, that includes removing it the two elements I mentioned above from the UI. |
Hi @Ankhell any news yet? Did you find some time to take out the UI parts or do you need explicit confirmation by @skaldarnar 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not solve the issue completely, but it's a step in the right direction. Will follow-up on the main menu notification in a separate PR.
Contains
Added new prop "overrideChildEnabledProp" to AbstractWidget to avoid overriding of child enabled property during initialization (In this exact case - by UIBox), modified UIFormat to process enabled field after Layout content initialization, disabled Identity Service Login features in UI
Contributes to #4104