feat(JOML): Migrate PlayerSystem #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed ViewDistance#chunkDistance to Vector3ic to avoid potential changes to properties in ViewDistance.
kBlaszczyk
approved these changes
May 8, 2020
|
Do you still have open questions about serialization for this PR? |
|
Merged with conflicts resolved (a rendering file was moved to CoreRendering, will commit the tiny change there), did general testing in a multiplayer setup, seems fine. Also changed the view distance several times to make sure it was fine. I figure the serialization note is about how we translate the view distance setting to |
Cervator
added
the
Topic: Architecture
Cervator
added a commit
to Terasology/CoreRendering
that referenced
this pull request
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed ViewDistance#chunkDistance to Vector3ic to avoid potential changes to properties in ViewDistance. Worked on migrating PlayerSystem to joml and made a small modification to ViewDistance. what kind of serialization do we do with ViewDistance with game settings.