Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JOML): Migrate BlockEntityRegistry #3923

Merged

Conversation

pollend
Copy link
Member

@pollend pollend commented May 1, 2020

updated BlockEntityRegistry with joml methods. the methods themselves back up their joml implementations, same as the worldprovider PR.

@pollend pollend changed the title updated EntityAwareWorldProvider feat(JOML): Migrate BlockEntityRegistry May 1, 2020
@pollend pollend marked this pull request as ready for review May 1, 2020 17:20
@pollend pollend requested a review from skaldarnar May 1, 2020 22:39
@Cervator Cervator added the Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. label May 2, 2020
@Cervator Cervator merged commit 6cdc19e into MovingBlocks:develop May 2, 2020
@Cervator
Copy link
Member

Cervator commented May 2, 2020

Looked easy enough, poked around in a mega-workspace and couldn't spot anything too odd. Merged! Thanks 👍

@Cervator Cervator added this to the v3.1.1 milestone May 2, 2020
@pollend pollend deleted the feature/joml-blockentityregistry branch September 26, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants