convered worldprovider to joml #3837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please have a look at the github release notes of the latest JOML releases. In particular this commit: JOML-CI/JOML@ba58982 |
|
This pull request introduces 2 alerts when merging 0c38618 into a9263f7 - view on LGTM.com new alerts:
|
|
Hooray Jenkins reported success with all tests good! |
I'll drop you a PR when I get the chance. probably later this week. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3811 and this PR mainly focused on world provider and ported over methods that use those methods. Some other classes had to be moved over because they use maps of block locations and blocks. I added a rounding method to JOMLUtility and we might want to look into adding a PR to JOML adding some kind of rounding constructor between Vector3f <--> Vector3i