Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Overflow in mesh constructor #38

Open
ancaandrei opened this issue Oct 27, 2021 · 9 comments
Open

[Bug] Overflow in mesh constructor #38

ancaandrei opened this issue Oct 27, 2021 · 9 comments
Assignees
Labels
0.6 Features for 0.6 bug Something isn't working

Comments

@ancaandrei
Copy link

Describe the bug
Error 'IndxBnds': Index out of bounds.
in AreaMesh at line 82
from global at line 9

To Reproduce
Steps to reproduce the behavior:

  1. Go to '../morpho/examples/cholesteric/cholesteric.morpho'
  2. Change dx to dx = 0.00000000001
  3. Run morpho5 cholesteric.morpho
  4. See error

Expected behavior
Error should not be there or the error should say that the mesh has an upper bound.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@ancaandrei ancaandrei added the bug Something isn't working label Oct 27, 2021
@ConduitDan ConduitDan self-assigned this Nov 2, 2021
@softmattertheory
Copy link
Contributor

What's the status of this?

@ConduitDan
Copy link
Collaborator

I have not yet started debugging this issue

@softmattertheory
Copy link
Contributor

Great can you de-assign yourself @ConduitDan and reassign when you're actively working on it. It may be something I jump in on (it's a minor error really...)

@ConduitDan ConduitDan removed their assignment Nov 23, 2021
@ConduitDan
Copy link
Collaborator

So i think what we need to do is add range count checking to the functions in mesh builder.
What is the current preferred method if the check fails. I don't think there is a way of throwing an error yet.

@ConduitDan
Copy link
Collaborator

I'll start with a printed error with a return nil

@softmattertheory softmattertheory added the 0.6 Features for 0.6 label Dec 7, 2021
@softmattertheory
Copy link
Contributor

Agreed @ConduitDan I think this needs 0.6 and error raising...

@ConduitDan
Copy link
Collaborator

We've got error raising now! I'm assigning to me!

@ConduitDan ConduitDan self-assigned this Feb 22, 2022
@softmattertheory
Copy link
Contributor

Woohoo error raising!

@ConduitDan
Copy link
Collaborator

Revisiting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 Features for 0.6 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants