Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Examples workflow incorrectly passes #263

Open
joshichaitanya3 opened this issue May 22, 2024 · 1 comment
Open

[Bug] Examples workflow incorrectly passes #263

joshichaitanya3 opened this issue May 22, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@joshichaitanya3
Copy link
Collaborator

Describe the bug
examples.py doesn’t catch for the case when it cannot run the morpho file itself, as is happening right now since the command is morpho5. So no examples are run, but it reports all passing. While changing it to morpho6 should do the trick for now, it would be great to catch and report this locally or through the CI.

P.S. The examples.py is currently passing all tests if run with morpho6 on my machine!
@joshichaitanya3 joshichaitanya3 added the bug Something isn't working label May 22, 2024
@joshichaitanya3 joshichaitanya3 mentioned this issue May 22, 2024
Merged
@joshichaitanya3 joshichaitanya3 added the good first issue Good for newcomers label May 23, 2024
@softmattertheory
Copy link
Contributor

Thanks for this @joshichaitanya3 ! We will fix this as we work on the 0.6.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshichaitanya3 @softmattertheory