Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Segfault upon incorrect assginment in function call #110

Open
joshichaitanya3 opened this issue Mar 4, 2022 · 2 comments
Open

[Bug] Segfault upon incorrect assginment in function call #110

joshichaitanya3 opened this issue Mar 4, 2022 · 2 comments
Labels
bug Something isn't working segfault/consistency error This is a crash, High priority

Comments

@joshichaitanya3
Copy link
Collaborator

Describe the bug
A typo in the constructor for FloryHuggins results in a segfault

To Reproduce

var m = Mesh("tetrahedron.mesh") // Can be found under test/functionals/floryhuggins

var mref = m.clone()

var lfh = FloryHuggins(mref. // This "." should be a ","
    a = 1.0,
    b = 1.0,
    c = 1.0,
    phi0=0.5
)

print lfh

Expected behavior
Some error indicating that the period is incorrect

@joshichaitanya3 joshichaitanya3 added the bug Something isn't working label Mar 4, 2022
@ConduitDan
Copy link
Collaborator

This segfaults in program_bindobject in vm/vim.c:100 obj it in invalid pointer
We should probably catch this as a parse error before this happens as mref. is not valid.

@ConduitDan ConduitDan added the segfault/consistency error This is a crash, High priority label Mar 29, 2022
@ConduitDan
Copy link
Collaborator

Assignment in fn call

@ConduitDan ConduitDan changed the title [Bug] Segfault upon incorrect construction of FloryHuggins [Bug] Segfault upon incorrect assginment in function call Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working segfault/consistency error This is a crash, High priority
Projects
None yet
Development

No branches or pull requests

2 participants