Add missing weakref.proxy #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagerard
reviewed
Aug 15, 2024
| @@ -188,7 +191,10 @@ def _mark_as_changed(self, key=None): | |||
| class EmbeddedDocumentList(BaseList): | |||
| def __init__(self, list_items, instance, name): | |||
| super().__init__(list_items, instance, name) | |||
| self._instance = instance | |||
There was a problem hiding this comment.
This is where the problem was, although self._instance was correctly converted to a weakref.proxy in super().__init__, it was being overwritten here.
This code is actually unnecessary since it's already handled in the parent class __init__. I'll push an updated version of this code (getting rid of EmbeddedDocumentList.init as it's not needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2820.