Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination isLast not returning the correct value #47

Closed
MinusKube opened this issue Feb 14, 2019 · 2 comments
Closed

Pagination isLast not returning the correct value #47

MinusKube opened this issue Feb 14, 2019 · 2 comments
Labels
bug

Comments

@MinusKube
Copy link
Owner

The pagination system goes one page too far when the item count is a multiple of the amount of items per page.
@MinusKube MinusKube added the bug label Feb 14, 2019
@crysis992
Copy link

After the fix isLast() returns false if there are 0 items in total for that GUI.
But it should return true when there are 0 items in total.

@MinusKube
Copy link
Owner Author

Oh, yeah, that's true.

@MinusKube MinusKube reopened this Feb 23, 2019
@MinusKube MinusKube changed the title Pagination goes one page too far Pagination isLast not returning the correct value Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crysis992 @MinusKube